feat(ext_remote): use git if installed to support any repo #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoiler: Planning to move all of extension downloader in there and rename it so we don't need these two classes (and eventually also the runner class and the extension controller.
… path rather than always user/repos Some hosts use other links like rhodecode using https://code.rhodecode.com/repo for the main project and https://code.rhodecode.com/u/user/repo for forks Regular git hosts without any web interface/api can use any path format (although these have no tarfile we can download)
…it installed and we aren't sure there are tarball endpoints sneaky bonus feat: you can now install local git paths. Ex: file:///home/me/my-code/my-ulauncher-extensions (file:// is optional)
I think this is already a big improvement from before when you had to manually copy or symlink your local repo, or run it with the weird long CLI instructions. Maybe we want a command on top of this to simply run your extension without installing it, but I think it's mostly over-thinking and a bad idea. If extensions are allowed to run from any path we need to keep track of that when we load/handle/change the extension settings for example. We normally use the extension id (derived from the URL) as the unique identifier to handle the settings and other things.
dccba8c to
c14e21b
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #1196 solved the issue with hitting GitHubs API rate limits, and also made the code simpler and more standardized, it still assumed that:
https://host.tld/user/repoThis was true for all the hosts we supported, and with this PR if the host is github, gitlab or codeberg or if the user doesn't have git installed it, it keeps using the old (tarball) install, as that's faster.
But if the user has git installed and trying to install from any other host it will instead use
git clone --bareandcheckout, which should work for any git host. This includes local paths such asfile:///home/me/my-code/my-ulauncher-extensions(thefile://prefix is optional, so you can use just/path/to/dir. It will store the url with thefile://-protocol either way).This has also been documented as a replacement from the debugging instructions we removed (63fc112). I think this is a good enough substitute and arguably fixes #818. While not as powerful as using
ipdbI think that was way too complicated ("leaky" abstraction). Extensions are not complicated enough to need that.The recommended/supported url format now is the HTTPS git repo you use for cloning (so
https://github.com/user/repo.gitrather than justhttps://github.com/user/repo). Either ones will work for github, gitlab or codeberg, but for other hosts we need the exact HTTPS GIT remote URL.Unfortunarely ExtensionRemote has now become quite complex and hard to test again, and I want to merge the remote and downloader classes (downloader is just a thin layer over remote now). So I don't want to add lots of tests and then have to rewrite them anyway.