Skip to content

Conversation

friday
Copy link
Member

@friday friday commented Dec 7, 2022

This PR makes Ulauncher dbus activatable, so you can launch it with gapplication launch io.ulauncher.Ulauncher, checking if the app id is already running at first, otherwise using the dbus service file to launch it.

The benefit is:

  1. When starting Ulauncher via the Desktop entry (using menu via another launcher or gapplication launch io.ulauncher.Ulauncher it now starts the systemd service for us instead of just running the app. This way ulauncher will restart if it crashes.
  2. This partly removes the need for ulauncher-toggle. One of two reasons to use ulauncher-toggle instead of ulauncher currently is that it's faster, but gapplication launch io.ulauncher.Ulauncher is actually even faster than ulauncher-toggle

The other reason to use ulauncher-toggle is to pass a query, but we should be able to do that with gapplication action io.ulauncher.Ulauncher set-query "asdf" or possibly just gapplication launch io.ulauncher.Ulauncher "asdf", although the latter case will expect a "asdf" to be a file )

Checklist

  • Verify that the test command ./ul test is passing (the CI server will check this if you don't)
  • Update the documentation according to your changes (when applicable)
  • Write unit tests for your changes (when applicable)

@friday friday force-pushed the feat/dbus-activatable branch from ed2ab90 to 712b808 Compare July 26, 2023 16:35
@friday friday marked this pull request as ready for review July 27, 2023 16:32
@friday friday merged commit a9a0162 into v6 Jul 27, 2023
@friday friday deleted the feat/dbus-activatable branch July 27, 2023 20:13
@friday friday added this to the 6.0.0 milestone Jul 27, 2023
@friday friday mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant