Rework extension keyword #1056
Merged
Rework extension keyword #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different solution instead of #287 (which was merged into the v6 branch but never released and now reverted)
This solution is better and will fix the issue without requiring extension devs to change their code. Extensions will receive a normalized user query where
get_keyword()returns the default they specified, regardless of what users changed the keyword to.It also removes the need to pass preferences to the event, and this will me simplify the API a bit more in another place.
Checklist
./ul testis passing (the CI server will check this if you don't)