Calculator: Add trigonometric methods and constants #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. I was not sure how to integrate my extension well, so this seems like the better solution. Thanks for your help. |
You did awesome work on your PR, but the calculator's was just not in a good state to extend with this type of functionality, which lead to the strange results. |
This was referenced Apr 17, 2022
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the actual functionality is exactly as implemented by @Henje in #1009, but this is rebased over #1014 which solved some of the issues with #1009.
is_enabled()has also been completely rewritten to use ast (just checking the root node) instead of regex, which made it easier to prevent false positives.Also added more tests.
It seems pretty solid to me after these changes.
Checklist
./ul testis passing (the CI server will check this if you don't)