Make ulauncher "toggle" by default if it's already running #987
Conversation
There was a problem hiding this comment.
Certainly a whole lot faster!
Perhaps the dbus stuff could go into a dedicated module, and the actual logic could be in a function which could get called at the bottom of the module automatically at import time. That way at the top of this file it can be just an import, still needing to be called before the heavy weight modules of course. Having a separate module which does a bunch of actual work at import time, including potentially exiting, can be a little odd for sure, but in this case it seems like a reasonable trade off for a cleaner header and nicer division of responsibility. Since we don't need the bus or instance objects later, if they get put into a function then they'd go away automatically as well.
8ee3fad to
54b6bc4
Compare
👍
Good idea. I didn't think about this. It sort of hides some important implementation details, but I think it's better also. Especially since we already do a similar thing with ulauncher.utils.xinit. I didn't implement it exactly like you suggested, but moved the UlauncherDbusService there too (kind of ugly considering how deeply it integrates with the window, but it shares the same dependencies as the other dbus code, so I think this looks cleaner. |
|
Closing in favor of #988 (unless that one is rejected for some reason, then we can reevaluate this solution) |
The title is a bit misleading, because ulauncher already does this, but it doesn't do it well.
This PR does four things:
ulauncherabout as fast asulauncher-toggle.--no-window(if it was, don't show the window of the running Ulauncher instance).ulauncher-toggle".--no-windowfrom the desktop entry. I think it's better if the desktop entry follows the experience of a regular "app", that you can "launch", while the systemd service file has--no-window, because it should run in the background.What's missing for this to be a perfect solution is the Wayland focus stealing fix from ulauncher-toggle, but that fix is unreliable anyway and I would want to replace it with something better (#986). I think we should keep
ulauncher-togglearound for a while anyway because people have that in their DE configs.Checklist
./ul testis passing (the CI server will check this if you don't)