Automatic event binding #936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gornostal This is the biggest API change probably. The link above to the forked extension shows some other things as well, but this part is about removing the event binding boilerplate code, and removing steps from the tutorial that the user don't need any more. I hope you agree. It's backwards compatible of course. |
|
Going to merge this one as well as I'm waiting to do more work on parts related to this and have a lot of time during the holiday, but I would still like to get feedback on the direction. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new blank methods on the
Extensionclass so users can extend and override those to bind the events without a ton of boilerplate code.See friday/ulauncher-encoder@08ad29e (this fork and commit works only with the PR applied)
Also see 228527f that renames the SystemExitEvent (which I don't think we even need?) to UnloadEvent/on_unload (old name still works for backward compatibility)
I have some further changes in mind for these like renaming the "preferences" event to "load" event, but wanted this to get merged first.
Checklist
./ul testis passing (the CI server will check this if you don't)