Support list as a shortcut/alias to RenderResultListAction #923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of this
...and returning
RenderResultListAction(list_of_items)
, you can now just returnlist_of_items
.This applies to all places RenderResultListAction was previously used, including the modes
handle_query
method, the extension query listener and and the extensionson_enter
andon_alt_enter
method.For the extension methods this change is backward compatible, but as step two to this (in a future major release) we should remove
RenderResultListAction
completely as an action and only support returning lists. Primarily because this API imports a lot of internals and it's problematic to expose it as part of the API #920 #285. I think it's also better to restrict the extension query listener to only accept this instead of any action, so that users get a more consistent and reliable experience (typing query always give them a list of choices), and extension developers get better guidelines to provide this. #864Checklist
./ul test
is passing (the CI server will check this if you don't)