Remove pyxdg dependency and switch to store state files in XDG_STATE_HOME #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #843
It's changing the location of all the state files and the log to XDG_STATE_HOME. Note that XDG_STATE_HOME is very new, and it's likely that Ulauncher will be the first app to use it on users systems (it was for me), but this isn't a problem :). XDG_DATA_HOME is now only used to store extensions, and XDG_CACHE_HOME is only used to store css files generated for themes that extends other themes. I'm not sure if this is something we can work around, so we don't use XDG_CACHE_HOME at all.
Planning on doing more work with how the state files are stored, and making them less backward compatible, by switching to json. Otherwise I wouldn't have moved them.