-
Notifications
You must be signed in to change notification settings - Fork 213
Rewrite apps logic using Gio.DesktopAppInfo.get_all() #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da4d85c
to
2a968ba
Compare
50c54cf
to
6ad73c5
Compare
I added back the test for AppResultItem and fixed them, and added a couple more tests for basic search. should_show() is probably the weirdest method in AppResultItem due to loading user settings and ignoring NoDisplay for |
6ad73c5
to
3676078
Compare
Work in progress implementation for #833
This removes the inotify dependency and file watching completely, as well as several other classes we don't really need (AppDb, AppIconCache). It's both due to using
Gio.DesktopAppInfo.get_all()
now to load the apps, but also for just a lot of refactoring in generalGio.DesktopAppInfo.get_all()
API does cache.app_stat_v3
. Previously it used the desktop file path as the identifier, but now it uses the desktop app id (which is what it should have used before, to avoid duplicating apps)Gio.DesktopAppInfo.get_all()
supports symlinks (if it doesn't we should ask users to submit an issue to the maintainers of Gnome/Glib).