fuzzy matching rewrite using new function get_matching_blocks() #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1518008 to
7d7a807
Compare
7d7a807 to
bfa8c05
Compare
|
Oh yeah this is really nice. The implementation is much improved from a code/logic standpoint, and the results are right on. I haven't been able to find any cases yet where the results did not line up with my expectations! 👍 👍 As far as I'm concerned this is ready to merge into |
troycurtisjr
approved these changes
Oct 16, 2021
I can think of a couple of cases, but I think the results are generally good enough not to have to handle them.
|
This was referenced Dec 2, 2021
Closed
Closed
3 tasks
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #824.
I wasn't planning to, but I reimplemented this for the v6 branch instead, with the major difference that it uses a new method
get_matching_blocks()which only exists in this branch (because it doesn't behave exactly the same in some cases).Was finally able to replace those last 30 lines of code to now to a much more sensible solution thanks to
get_matching_blocks(), and also removed the condition #824 reintroduced.The character weighting is much smaller, and the new code doesn't bump up everything to 100% like the old one did with very short queries.
The highlighter and matcher uses the same implementation now (even the same function call, since it's memoized). Before this, the highligher used a completely different implementation and sometimes would display misleading results.
Might need some need tuning still, but I'm happy with the results, because getting the matchmaking blocks means we can understand it better and score it better, with less code duplication.