Skip to content

Fix hardcoded paths for writing JSON #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 22, 2021
Merged

Fix hardcoded paths for writing JSON #241

merged 4 commits into from
Jul 22, 2021

Conversation

astrochun
Copy link
Contributor

@astrochun astrochun commented Jul 22, 2021 •
edited
Loading

Description

This ensures that the Qualtrics class determines the current path. Also, I identified another hardcoded path in ReadmeClass.

Closes #240

Update Changelog

  • CHANGELOG.md

Bump version

v1.1.5 -> v1.1.6

Screenshots or additional context

Testing (if applicable)

@astrochun astrochun added this to the v1.2.0 milestone Jul 22, 2021
@astrochun astrochun added bug Something isn't working curation Pertains to aspects of curation, including workflow management p1 Issues affecting production, multiple users labels Jul 22, 2021
@astrochun astrochun self-assigned this Jul 22, 2021
@astrochun astrochun requested a review from zoidy July 22, 2021 16:58
@astrochun astrochun force-pushed the bug/240_save_metadata_incorrect_path branch from 99586b8 to 8d080f7 Compare July 22, 2021 17:00
astrochun
astrochun commented Jul 22, 2021
View reviewed changes
Copy link
Contributor Author

@astrochun astrochun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and I was able to confirm a few end-to-end test:

  • prereq_script ran without any issues
  • update_readme ran without any issues if no file changes occur
  • update_readme ran as expected if I physically modified the README.txt to trigger and update

@astrochun astrochun merged commit a76ed1d into master Jul 22, 2021
@astrochun astrochun deleted the bug/240_save_metadata_incorrect_path branch July 22, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoidy zoidy zoidy approved these changes

Assignees

@astrochun astrochun

Labels
bug Something isn't working curation Pertains to aspects of curation, including workflow management p1 Issues affecting production, multiple users
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Bug: update_readme fails due to issue with saving README metadata as JSON file
2 participants
@astrochun @zoidy