Skip to content

Enhancement: Double digit for version #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 29, 2021
Merged

Enhancement: Double digit for version #225

merged 4 commits into from
Jun 29, 2021

Conversation

astrochun
Copy link
Contributor

@astrochun astrochun commented Jun 22, 2021 •
edited
Loading

Description

This directly fixes the need to use zero padding on folder name (e.g., "v01")

Closes #224

Test plan

  • Retrieve data with get_data
  • Move folder with move_next, move_back and move_publish

Update Changelog

  • CHANGELOG.md updated for unreleased changes

Resources

To update existing files using old schema for version:

ls -d /mnt/block1_sfo2/curation/*/*/v? | awk '{printf("mv %s ", $0); sub(/\/v/,"\/v0"); print}' | sh

@astrochun astrochun added this to the v1.2.0 milestone Jun 22, 2021
@astrochun astrochun added curation Pertains to aspects of curation, including workflow management enhancement New feature or request preservation Related to data preservation labels Jun 22, 2021
@astrochun astrochun self-assigned this Jun 22, 2021
@astrochun astrochun requested a review from zoidy June 22, 2021 20:40
astrochun
astrochun commented Jun 22, 2021
View reviewed changes
Copy link
Contributor Author

@astrochun astrochun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and passed end-to-end curation testing. No need to bump version for deployment (manually deploy with git.

Note that after deployment the existing folders will need to be renamed otherwise any move_* will fail.

@zoidy
Copy link
Collaborator

zoidy commented Jun 28, 2021 •
edited
Loading

Note that after deployment the existing folders will need to be renamed otherwise any move_* will fail.

This is an important thing to highlight in the help message on curation1. Unless everything will be renamed prior to deployment

@astrochun
Copy link
Contributor Author

astrochun commented Jun 28, 2021 •
edited
Loading

Note that after deployment the existing folders will need to be renamed otherwise any move_* will fail.

This is an important thing to highlight in the help message on curation1. Unless everything will be renamed prior to deployment

This is a one-time change so it doesn't need to be highlight in help message. Quite simply there will be no impact to move_* commands as every folder will be consistent. This is simply a note to run the above awk command during the deployment stage.

@astrochun astrochun merged commit 7edebeb into master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoidy zoidy zoidy approved these changes

Assignees

@astrochun astrochun

Labels
curation Pertains to aspects of curation, including workflow management enhancement New feature or request preservation Related to data preservation
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Enhancement: Double digit for version
2 participants
@astrochun @zoidy