Skip to content

Fixed position of member metric for latest post #24363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

Fixed position of member metric for latest post #24363

merged 1 commit into from
Aug 6, 2025

Conversation

peterzimon
Copy link
Contributor

ref https://linear.app/ghost/issue/ENG-2455/fix-position-of-member-metric-on-latest-posts

  • The member metric (ie. no. of new members the post generated) in the Latest post section on Analytics overview had to be positioned as the last item, if the post [has been sent as an email] and [there's no web analytics data (email-only post) or web analytics is turned off] — the reason for this is purely aesthetical: in this case it looks better if the member metric appears in the 2nd row of the grid. The current condition had not contained the first part ("has been sent as an email"), this PR added it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2025 •
edited
Loading

Walkthrough

The conditional logic determining the CSS grid placement for the member growth metric in the LatestPost component was updated. The new logic requires that email metrics are being displayed, in addition to either web metrics not being shown or web analytics being disabled, for the member metric to move to the second row and first column of the grid. This change refines the conditions under which the grid position of the member metric is altered, making it dependent on the simultaneous presence of email metrics and the previous web-related conditions. No changes were made to exported or public entities.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4d8908 and 4ec267c.

📒 Files selected for processing (1)
  • apps/stats/src/views/Stats/Overview/components/LatestPost.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/stats/src/views/Stats/Overview/components/LatestPost.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Setup
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ta-fix-metric-grid-position

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@peterzimon peterzimon force-pushed the ta-fix-metric-grid-position branch from e4a72cb to e4d8908 Compare July 22, 2025 09:31
@ErisDS ErisDS added the ready-to-merge Blocked by code freeze label Aug 4, 2025
@peterzimon
Fixed position of member metric for latest post
4ec267c 
ref https://linear.app/ghost/issue/ENG-2455/fix-position-of-member-metric-on-latest-posts

- The member metric (ie. no. of new members the post generated) in the Latest post section on Analytics overview had to be positioned as the last item, if the post [has been sent as an email] and [there's no web analytics data (email-only post) or web analytics is turned off] — the reason for this is purely aesthetical: in this case it looks better if the member metric appears in the 2nd row of the grid. The current condition had not contained the first part ("has been sent as an email"), this PR added it.
@peterzimon peterzimon force-pushed the ta-fix-metric-grid-position branch from e4d8908 to 4ec267c Compare August 6, 2025 10:34
@peterzimon peterzimon requested a review from 9larsons August 6, 2025 10:35
@peterzimon peterzimon merged commit 11c3074 into main Aug 6, 2025
23 checks passed
@peterzimon peterzimon deleted the ta-fix-metric-grid-position branch August 6, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9larsons 9larsons 9larsons approved these changes

Assignees
No one assigned
Labels
ready-to-merge Blocked by code freeze
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterzimon @9larsons @ErisDS