Skip to content

Fixed paid members showing up in post list #24591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 3, 2025
Merged

Fixed paid members showing up in post list #24591

merged 4 commits into from
Aug 3, 2025

Conversation

peterzimon
Copy link
Contributor

@peterzimon peterzimon commented Aug 3, 2025 •
edited
Loading

ref https://linear.app/ghost/issue/PROD-2377/analytics-growth-top-content-sources-shows-paid-related-columns

  • In the main post list and Analytics top post list stats popup, paid membership related columns are displayed in the Top Sources table even though paid membership is turned off for the publication.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 3, 2025 •
edited
Loading

Walkthrough

The changes introduce a conditional rendering of the "Paid" members metric in the analytics section of a post list item. This is controlled by a paidMembersEnabled flag, ensuring that the metric is only displayed when this feature is enabled. Additionally, the membersUtils service is injected into the relevant component to provide access to this flag. Similarly, in the stats frontend, the "New members" tooltip conditionally shows the "Paid members" metric based on the same flag. No other logic or public API changes are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~6 minutes

Possibly related PRs

Suggested reviewers

  • cmraible

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01618c4 and 843c7df.

📒 Files selected for processing (1)
  • apps/stats/src/views/Stats/Overview/components/TopPosts.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/stats/src/views/Stats/Overview/components/TopPosts.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ta-hide-paid-members-post-list

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@peterzimon peterzimon requested review from cmraible and 9larsons August 3, 2025 04:41
@peterzimon
Fixed paid members showing up in post list
61ac0fe 
ref https://linear.app/ghost/issue/PROD-2377/analytics-growth-top-content-sources-shows-paid-related-columns

- In the post list stats popup, paid membership related columns are displayed in the Top Sources table even though paid membership is turned off for the publication.
@peterzimon peterzimon force-pushed the ta-hide-paid-members-post-list branch from d96d7a7 to 61ac0fe Compare August 3, 2025 14:29
9larsons
9larsons approved these changes Aug 3, 2025
View reviewed changes
Copy link
Contributor

@9larsons 9larsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@9larsons 9larsons enabled auto-merge (squash) August 3, 2025 15:31
@9larsons 9larsons merged commit a627522 into main Aug 3, 2025
23 checks passed
@9larsons 9larsons deleted the ta-hide-paid-members-post-list branch August 3, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9larsons 9larsons 9larsons approved these changes

@cmraible cmraible Awaiting requested review from cmraible

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterzimon @9larsons