Skip to content

Conversation

DocKnight86
Copy link
Collaborator

@DocKnight86 DocKnight86 commented Oct 11, 2024

Screenshot 2024-10-11 131423
Screenshot 2024-10-11 131257
Before fix ^

After Fix >

Setting Base: 0.1, Converted to FixedPoint: 1
Old Base: 0, New Value (sv): 1
Skill Healing changed from 0 to 0.1
Setting Base: 0.2, Converted to FixedPoint: 2
Old Base: 1, New Value (sv): 2
Skill Healing changed from 0.1 to 0.2
Setting Base: 0.30000000000000004, Converted to FixedPoint: 3
Old Base: 2, New Value (sv): 3
Skill Healing changed from 0.2 to 0.3
Setting Base: 0.4, Converted to FixedPoint: 4
Old Base: 3, New Value (sv): 4
Skill Healing changed from 0.3 to 0.4
Setting Base: 0.5, Converted to FixedPoint: 5
Old Base: 4, New Value (sv): 5
Skill Healing changed from 0.4 to 0.5
Setting Base: 0.6, Converted to FixedPoint: 6
Old Base: 5, New Value (sv): 6
Skill Healing changed from 0.5 to 0.6
Setting Base: 0.7, Converted to FixedPoint: 7
Old Base: 6, New Value (sv): 7
Skill Healing changed from 0.6 to 0.7
Setting Base: 0.7999999999999999, Converted to FixedPoint: 8
Old Base: 7, New Value (sv): 8
Skill Healing changed from 0.7 to 0.8
Setting Base: 0.9, Converted to FixedPoint: 9
Old Base: 8, New Value (sv): 9
Skill Healing changed from 0.8 to 0.9
Setting Base: 1, Converted to FixedPoint: 10
Old Base: 9, New Value (sv): 10
Skill Healing changed from 0.9 to 1
Setting Base: 1.1, Converted to FixedPoint: 11
Old Base: 10, New Value (sv): 11
Skill Healing changed from 1 to 1.1
Setting Base: 1.2000000000000002, Converted to FixedPoint: 12
Old Base: 11, New Value (sv): 12
Skill Healing changed from 1.1 to 1.2
Setting Base: 1.3, Converted to FixedPoint: 13
Old Base: 12, New Value (sv): 13
Skill Healing changed from 1.2 to 1.3
Setting Base: 1.4000000000000001, Converted to FixedPoint: 14
Old Base: 13, New Value (sv): 14
Skill Healing changed from 1.3 to 1.4
Setting Base: 1.5, Converted to FixedPoint: 15
Old Base: 14, New Value (sv): 15
Skill Healing changed from 1.4 to 1.5
Setting Base: 1.6, Converted to FixedPoint: 16
Old Base: 15, New Value (sv): 16
Skill Healing changed from 1.5 to 1.6

Before certain values like 0.7 to 0.8 were always rounding down when 0.1 was applied.

Copy link

@TrueUO TrueUO merged commit 48e6a31 into master Oct 11, 2024
2 checks passed
@TrueUO TrueUO deleted the FixesSkillGainRoundingIssues branch October 11, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants