-
-
Notifications
You must be signed in to change notification settings - Fork 154
Update docker-compose.yml
#309
Update docker-compose.yml
#309
Conversation
Also added comments to `docker-compose.yml` and removed unused volumes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change in spacing? I think 2 is well suited for yaml and is what is already being used.
Just my opinion though, I'll let Elian decide.
@rauenzi , I think it might be caused by the editorconfig we have, I think I made a similar accidental change on my side when messing with the Docker build. @slashtechno , if it would be possible for you to revert the change in spacing, it would be appreciated since it makes for a cleaner diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Updated
docker-compose.yml
to use the image for TriliumNext, in addition to adding some more comments.Related to triliumnext/Docs#102