Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

Conversation

slashtechno
Copy link

@slashtechno slashtechno commented Aug 7, 2024

Updated docker-compose.yml to use the image for TriliumNext, in addition to adding some more comments.

Related to triliumnext/Docs#102

Also added comments to `docker-compose.yml` and removed unused volumes
Copy link
Contributor

@zerebos zerebos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change in spacing? I think 2 is well suited for yaml and is what is already being used.

Just my opinion though, I'll let Elian decide.

@eliandoran
Copy link
Contributor

Why the change in spacing? I think 2 is well suited for yaml and is what is already being used.

@rauenzi , I think it might be caused by the editorconfig we have, I think I made a similar accidental change on my side when messing with the Docker build.

@slashtechno , if it would be possible for you to revert the change in spacing, it would be appreciated since it makes for a cleaner diff.

@eliandoran eliandoran marked this pull request as draft August 7, 2024 21:21
@slashtechno slashtechno marked this pull request as ready for review August 8, 2024 13:08
Copy link
Contributor

@chesspro13 chesspro13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eliandoran eliandoran merged commit 6a45942 into TriliumNext:develop Aug 8, 2024
@eliandoran eliandoran added this to the v0.90.4 milestone Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants