Skip to content

feat: add message IDs to private group messages #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat: add message IDs to private group messages #2727

merged 1 commit into from
Mar 7, 2024

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Mar 6, 2024 •
edited by iphydf
Loading

This change is Reviewable

@JFreegman JFreegman added the enhancement New feature for the user, not a new feature for build script label Mar 6, 2024
@JFreegman JFreegman added this to the v0.2.19 milestone Mar 6, 2024
@JFreegman JFreegman requested a review from Green-Sky March 6, 2024 16:44
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 73.13%. Comparing base (99e0bcc) to head (7b1db6a).

Files Patch % Lines
toxcore/tox.c 30.76% 9 Missing ⚠️
toxcore/events/group_private_message.c 54.54% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2727      +/-   ##
==========================================
+ Coverage   73.05%   73.13%   +0.07%     
==========================================
  Files         149      149              
  Lines       30499    30516      +17     
==========================================
+ Hits        22282    22317      +35     
+ Misses       8217     8199      -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JFreegman JFreegman force-pushed the group_message_ids branch 3 times, most recently from 64a21a1 to 2b0bd4f Compare March 6, 2024 17:10
@Green-Sky
Copy link
Member

you need to adjust the event here:

c-toxcore/other/event_tooling/generate_event_c.cpp

Lines 744 to 761 in b3c3c49

"Group_Message",
{
EventTypeTrivial{"uint32_t", "group_number"},
EventTypeTrivial{"uint32_t", "peer_id"},
EventTypeTrivial{"Tox_Message_Type", "type"},
EventTypeByteRange{"message", "message_length", "length"}, // the latter two are ideally the same
EventTypeTrivial{"uint32_t", "message_id"},
}
},
{
"Group_Private_Message",
{
EventTypeTrivial{"uint32_t", "group_number"},
EventTypeTrivial{"uint32_t", "peer_id"},
EventTypeTrivial{"Tox_Message_Type", "type"},
EventTypeByteRange{"message", "message_length", "length"}, // the latter two are ideally the same
}
},

@JFreegman JFreegman force-pushed the group_message_ids branch 5 times, most recently from 23b5dcc to 0a93263 Compare March 7, 2024 14:45
@Green-Sky Green-Sky changed the title feat: add message IDs to private group packets feat: add message IDs to private group messages Mar 7, 2024
@Green-Sky
Copy link
Member

Green-Sky commented Mar 7, 2024 •
edited
Loading

@JFreegman commit message is wrong, needs to be messages, not packets.

Green-Sky
Green-Sky requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message is wrong

@JFreegman JFreegman force-pushed the group_message_ids branch from 0a93263 to f64894b Compare March 7, 2024 15:26
@JFreegman JFreegman force-pushed the group_message_ids branch from f64894b to 7b1db6a Compare March 7, 2024 15:39
@JFreegman JFreegman merged commit 7b1db6a into TokTok:master Mar 7, 2024
@JFreegman JFreegman deleted the group_message_ids branch March 7, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Green-Sky Green-Sky Green-Sky approved these changes

Assignees

@JFreegman JFreegman

Labels
enhancement New feature for the user, not a new feature for build script
Milestone
v0.2.19
Development

Successfully merging this pull request may close these issues.
2 participants
@JFreegman @Green-Sky