cleanup: skip a do_gc iteration before removing peers marked for deletion #2573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5352bd to
2e73701
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2573 +/- ##
==========================================
+ Coverage 66.92% 66.96% +0.04%
==========================================
Files 148 148
Lines 30271 30275 +4
==========================================
+ Hits 20259 20275 +16
+ Misses 10012 10000 -12 ☔ View full report in Codecov by Sentry. |
iphydf
approved these changes
Jan 16, 2024
…tion This fixes an issue with events where we try to make queries on peers that no longer exist internally
2e73701 to
21a8ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with events where we try to make queries on peers that no longer exist internally
This change is