cleanup: Run clang-tidy on headers, as well. #2507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2507 +/- ##
==========================================
- Coverage 68.97% 68.95% -0.03%
==========================================
Files 89 89
Lines 27772 27772
==========================================
- Hits 19157 19151 -6
- Misses 8615 8621 +6 ☔ View full report in Codecov by Sentry. |
nurupo
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Reviewed 11 of 11 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
|
GitHub still displays this as 2 commits even though fad6e4e is already in master, huh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is