Correctly handle --keep_going #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will work on making this logic more testable soon Fixes fineGrainedHashExternalRepos parameter issue #267 Signed-off-by: Maxwell Elliott <maxwell.elliott@gotinder.com>
|
@tinder-maxwellelliott The fix looks good, thank you! I don't have the issue currently, ran across it in march so added more context to the pre-existing issue, but didn't end up needing to solve it. |
Signed-off-by: Maxwell Elliott <maxwell.elliott@gotinder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will work on making this logic more testable soon
Fixes fineGrainedHashExternalRepos parameter issue #267
Signed-off-by: Maxwell Elliott maxwell.elliott@gotinder.com