feat: TransIP support #274
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for TransIP as a new DNS provider by integrating the gotransip library.
- Adds TransIP-specific settings validations in settings.go
- Introduces a new TransIP provider implementation and integrates it into the provider factory
- Updates the README documentation to include TransIP configuration examples
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/utils/settings.go | Adds error checks for email and login token when the provider is set to TransIP. |
| internal/utils/constants.go | Introduces the TRANSIP constant to support the new provider. |
| internal/provider/transip/transip_handler.go | Implements the TransIP provider logic using the gotransip library. |
| internal/provider/factory.go | Adds a case for initializing the TransIP provider in the factory. |
| README.md | Documents configuration and usage details for TransIP. |
Files not reviewed (1)
- go.mod: Language not supported
|
@Tinyblargon Thanks for the contribution. I checked the Auto CI result, there is only one error for the comment. |
|
@TimothyYe I'll fix that asap. But is the added library an issue? Noticed all the other implementations don't use the SDKs for those providers. For example, the CloudFlare Go SDK. Or is that because the Go SDKs came after this project already supported those cloud providers? |
|
@Tinyblargon I guess so. GoDNS's support for Cloudflare came relatively early, likely due to some historical reasons. It doesn't directly use Go's SDK, but instead implements their RESTful API. |
This PR adds support for TransIP, and does this through gotransip.