cloudflare: Fix record updates due to empty zone ID #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare API in some cases returns an empty ZoneID for the zones endpoint. Due to that the subsequent update calls fail. This patch addresses this issue by manually specifying the zone ID in cases where it is empty. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
|
Thanks for the contribution. |
|
Could you please rebuild the docker container with the latest changes and push it to your registry? Ideally a CI job should take care of it, if needed I can contribute the code for that :) |
|
The release pipeline is running now, pls check for the registry later, the latest version is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudflare API in some cases returns an empty ZoneID for the zones endpoint. Due to that the subsequent update calls fail.
This patch addresses this issue by manually specifying the zone ID in cases where it is empty.