Install serialization C API headers regardless of build configuration. #5530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
approved these changes
Jun 3, 2025
|
/backport to release-2.28 |
|
Started backporting to release-2.28: https://github.com/TileDB-Inc/TileDB/actions/runs/15898064881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we install
tiledb_serialization.honly if the Core is built withTILEDB_SERIALIZATIONenabled. This is not ideal, as it forces downstream projects to include compile-time logic to conditionally includetiledb_serialization.h. Context: TileDB-Inc/TileDB-Py#2199.This PR updates the behavior to always install
tiledb_serialization.h. The compiled binaries already always export the C APIs, which will simply fail at runtime if serialization is disabled.Closes CORE-232
TYPE: BUILD
DESC: Install serialization C API headers regardless of build configuration.