[Backport release-2.28] Avoid throwing on missing Profile parameters in getter APIs. (#5552) #5588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatia
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Profile getter C and CPP APIs to avoid throwing exceptions when a requested parameter is not found in the internal
std::map. Instead, the getters now return anullptr(C API) orstd::nullopt(CPP API) to signal that the key is missing.This behavior aligns with the rest of our APIs, where "not found" cases are generally handled without exceptions. Throwing is now reserved for actual errors.
TYPE: IMPROVEMENT
DESC: Avoid throwing on missing Profile parameters in getter APIs.