Fix semantics of tiledb_vfs_create_dir on local filesystem.
#5579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9b7a73 to
d3b62d0
Compare
e4a886f to
a31223f
Compare
tiledb_vfs_create_dir on local filesystem.
a31223f to
63781f6
Compare
63781f6 to
728e9b4
Compare
teo-tsirpanis
commented
Jul 17, 2025
| if (status != 0) { | ||
| auto err = errno; | ||
| if (err == EEXIST) { | ||
| // Do not fail if directory already existed. |
There was a problem hiding this comment.
This is the documented behavior, so I'm treating this change as a bug fix.
TileDB/tiledb/api/c_api/vfs/vfs_api_external.h
Lines 229 to 230 in 639322f
kounelisagis
approved these changes
Jul 17, 2025
| auto status = mkdir(path.c_str(), directory_permissions_); | ||
| if (status != 0) { | ||
| auto err = errno; | ||
| if (err == EEXIST) { |
There was a problem hiding this comment.
I would prefer to check whether err != EEXIST and throw the error in that case, rather than returning when err == EEXIST.
There was a problem hiding this comment.
I think the current way is better; it indicates that throwing on an error is the general case, and ignoring the error is the special case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CORE-268.
Tests added. The Windows implementation already creates parent directories.
TYPE: BUG
DESC: Fixed the
tiledb_vfs_create_dirfunction to automatically create non-existent parent directories on POSIX.TYPE: BUG
DESC: Fixed the
tiledb_vfs_create_dirfunction to not fail when the directory already exists.