Fix Subarray::add_point_ranges_var to use the appropriate variable data Range constructor.
#5560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data`Range` constructor.
teo-tsirpanis
approved these changes
Jun 26, 2025
|
/backport to release-2.28 |
|
Started backporting to release-2.28: https://github.com/TileDB-Inc/TileDB/actions/runs/15911632573 |
kounelisagis
added a commit
that referenced
this pull request
Jul 1, 2025
…en range and dimension. (#5569) Previously, when adding a range to a dimension in `Subarray::add_range`, there was no validation to ensure that the variable-size property of the range matched that of the target dimension. This could lead to bugs, especially for variable-length dimensions, as was the case in #5490, which was later addressed in #5560. This PR adds a validation check to ensure that the `var_size` of the range matches the `var_size` of the corresponding dimension. If there is a mismatch, a `SubarrayException` is thrown early. Closes CORE-283 --- TYPE: IMPROVEMENT DESC: Fix `Subarray::add_range` to validate var_size consistency between range and dimension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5490,
Subarray::add_point_ranges_varwas introduced as a user-friendly alternative to avoid the need to manually iterate and construct(point, point)tuples for each query point. However, the initial implementation was using aRangeconstructor intended for fixed-sized data. This was incorrect for variable-sized dimensions since it didn't utilize the appropriateset_range_var()method, which is responsible for correctly setting internal attributes such asvar_size_.Additionally, the test for this functionality didn't use the correct getter for retrieving variable-sized ranges from the subarray.
TYPE: BUG
DESC: Fix
Subarray::add_point_ranges_varto use the appropriate variable dataRangeconstructor.