Skip to content

Support using ipv6 in make_client/make_server method #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2024
Merged

Support using ipv6 in make_client/make_server method #261

merged 2 commits into from
Apr 18, 2024

Conversation

cocolato
Copy link
Collaborator

Fix: #204

aisk
aisk requested changes Apr 15, 2024
View reviewed changes
@cocolato cocolato requested a review from aisk April 16, 2024 12:11
@aisk
Copy link
Member

aisk commented Apr 18, 2024

There are still some codes where socket_family is applied to unix domain sockets.

@cocolato
Copy link
Collaborator Author

There are still some codes where socket_family is applied to unix domain sockets.

Does this mean that when users pass in the unix_socket option, they will not be supported to pass in the additional socket_family option?

@aisk
Copy link
Member

aisk commented Apr 18, 2024

Yes, the unix domain socket's socket_family must be AF_UNIX. See: https://www.ibm.com/docs/en/i/7.3?topic=characteristics-socket-address-family

cocolato
cocolato commented Apr 18, 2024
View reviewed changes
@cocolato
Copy link
Collaborator Author

Yes, the unix domain socket's socket_family must be AF_UNIX. See: https://www.ibm.com/docs/en/i/7.3?topic=characteristics-socket-address-family

Updated.

aisk
aisk reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@aisk aisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one suggestion left, otherwise this change looks good to me.

@cocolato @aisk
Update thriftpy2/rpc.py
2d35262 
Co-authored-by: AN Long <aisk@users.noreply.github.com>
@aisk aisk merged commit 516cc30 into Thriftpy:master Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aisk aisk aisk requested changes

@ethe ethe ethe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thriftpy2 whether support using in ipv6
3 participants
@cocolato @aisk @ethe