Skip to content

#1876 Replace JwtSecurityTokenHandler with JsonWebTokenHandler in the Authentication docs according to breaking changes in .NET 8 Auth #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 19, 2024
Merged

#1876 Replace JwtSecurityTokenHandler with JsonWebTokenHandler in the Authentication docs according to breaking changes in .NET 8 Auth #2238

merged 5 commits into from
Dec 19, 2024

Conversation

jvanderlei
Copy link
Contributor

@jvanderlei jvanderlei commented Dec 13, 2024 •
edited by raman-m
Loading

Fixes #1876

Proposed Changes

  • Fixed the type updated on .NET 8 v.7

@jvanderlei jvanderlei marked this pull request as draft December 13, 2024 13:16
@jvanderlei
Copy link
Contributor Author

@raman-m The docs should cite that may also be pertinent to Azure AD, as said in #1876?

I'll start developing the example for Okta integration

@raman-m
Copy link
Member

raman-m commented Dec 13, 2024

Thanks for opening PR!
In my opinion, we have to add a new foot note with an explanation of this breaking change. So, please add a short paragraph with 2-3 sentences!

@jvanderlei jvanderlei marked this pull request as ready for review December 13, 2024 15:51
@raman-m raman-m changed the title JwtSecurityToken to JsonWebToken. #1876 JwtSecurityToken to JsonWebToken Dec 14, 2024
@raman-m raman-m added bug Identified as a potential bug Authentication Ocelot feature: Authentication NET9 .NET 9 release documentation Needs a documentation update labels Dec 14, 2024
@raman-m raman-m added this to the .NET 9 milestone Dec 14, 2024
raman-m
raman-m requested changes Dec 14, 2024
View reviewed changes
Copy link
Member

@raman-m raman-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previously stated in the linked issue: #1876 (comment), acceptance testing is mandatory. Please add acceptance tests and, optionally, unit.

docs/features/authentication.rst Outdated
Comment on lines 185 to 187
JsonWebTokenHandler.DefaultInboundClaimTypeMap.Add("scp", "scope");

`Issue 446 <https://github.com/ThreeMammals/Ocelot/issues/446>`_ contains some code and examples that might help with Okta integration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I believe line 187, referencing issue [Question] OIDC Auth and 401 #446 can be removed due to its outdated nature, correct? Should we always remap claims for Okta?
  2. What about utilizing Clear() method as in the MS Learn documentation?

@raman-m
Copy link
Member

raman-m commented Dec 18, 2024 •
edited
Loading

Hi! What's the progress here?

@raman-m
Copy link
Member

raman-m commented Dec 18, 2024 •
edited
Loading

@jvanderlei Joaop, please note the document looks good now.
When will you have time to work on the Okta sample?
I do not think it is a difficult task if you have developed Okta solutions before.

@raman-m
Copy link
Member

raman-m commented Dec 19, 2024

@jvanderlei Are you online?

@raman-m raman-m changed the title #1876 JwtSecurityToken to JsonWebToken #1876 Replace JwtSecurityToken with JsonWebToken in the Authentication docs according to breaking changes in .NET 8 Auth Dec 19, 2024
@raman-m raman-m changed the title #1876 Replace JwtSecurityToken with JsonWebToken in the Authentication docs according to breaking changes in .NET 8 Auth #1876 Replace JwtSecurityTokenHandler with JsonWebTokenHandler in the Authentication docs according to breaking changes in .NET 8 Auth Dec 19, 2024
raman-m
raman-m approved these changes Dec 19, 2024
View reviewed changes
docs/features/authentication.rst
Comment on lines +179 to +181
JsonWebTokenHandler.DefaultInboundClaimTypeMap.Remove("scp");
JsonWebTokenHandler.DefaultInboundClaimTypeMap.Add("scp", "scope");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key changes!

@raman-m raman-m merged commit 9304dd2 into ThreeMammals:develop Dec 19, 2024
1 check passed
@raman-m
Copy link
Member

raman-m commented Dec 19, 2024

TODO

@raman-m raman-m mentioned this pull request Apr 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raman-m raman-m raman-m approved these changes

Assignees

@jvanderlei jvanderlei

Labels
Authentication Ocelot feature: Authentication bug Identified as a potential bug documentation Needs a documentation update NET9 .NET 9 release
Projects
None yet
Milestone
.NET 9
Development

Successfully merging this pull request may close these issues.

Authentication docs could do with a note around .NET 8 changes
2 participants
@jvanderlei @raman-m