Skip to content

Conversation

kerkerj
Copy link
Contributor

@kerkerj kerkerj commented Jan 19, 2021

As the title mentioned, added an example test to show it integrates with sentry and zap
(used zaptest/observer and mock sentry transport ;))

@Dombo
Copy link

Dombo commented Jan 24, 2021

Am I right in my assessment that without this approach, you risk losing events if the main loop exits before the sentry client has time to send the event?

@kerkerj
Copy link
Contributor Author

kerkerj commented Jan 25, 2021

Am I right in my assessment that without this approach, you risk losing events if the main loop exits before the sentry client has time to send the event?

Hi @Dombo, I am not sure what this approach means? Could you explain more about what you thought? I am happy to answer it :)
From my understanding, sentry uses #Flush to prevent unintentionally dropping events. (which is what you mentioned.)

@TheZeroSlave TheZeroSlave merged commit db5f436 into TheZeroSlave:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants