Skip to content

Conversation

jpmeijers
Copy link
Collaborator

pb.h should be an include from the local directory, therefore #include "ph.h" and not #include <pb.h>.

Compile will fail if this library is not being included from the Arduino global path, but rather from the local directory. For example if the directory structure looks like this:

example/
- example.ino
- src/
-- arduino-device-lib/

and inside example.ino we include the library as follows:

#include "src/arduino-device-lib/src/TheThingsNetwork.h"

After this change the compile is successful.

Note:
If the library is present in both the Arduino libraries directory as well as the local directory, compilation might fail due to duplicate definitions. Keep this in mind during testing.

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Those *.ph.h files are generated so they'll be overwritten, but ok

Can you sign CLA? Did your email address change?

@jpmeijers
Copy link
Collaborator Author

Strange. Seems like I had to re-authorize the CLA Assistant with Github OAuth2 for it to pick up my previous signed CLA.

@johanstokking johanstokking merged commit e3115cc into master Jul 15, 2019
@johanstokking johanstokking deleted the bug/pb_global_includes branch July 15, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants