Skip to content

Conversation

ohaiibuzzle
Copy link

Change the PlayTools install behavior so

  • Respect default settings
  • Allows an overriding key to be used to override defaults
  • Seamless for older users

@ohaiibuzzle ohaiibuzzle force-pushed the fix/playtoolsbehavior branch from 96bfecf to b99553c Compare October 27, 2022 04:05
@TheMoonThatRises TheMoonThatRises merged commit bc1fb8d into TheMoonThatRises:fix/playtoolsinstallclarity Oct 27, 2022
TheMoonThatRises added a commit that referenced this pull request Nov 2, 2022
* fix: make install playtools clearer

* feat: change PlayTools installation behavior (#1)

* simplify if-statement + swiftlint

* fix trailing whitespace

* clarify PlayTools make break certain apps

* fix AKInterface installing despite no PlayTools

Restores app to original state

* allow user to cancel install with popup

* make install preferences consistent with uninstall

* remove PlugIn directory if it is empty

Some apps use the PlugIn directory to store their own plugins

* Update PlayCover/en.lproj/Localizable.strings

Co-authored-by: OHaiiBuzzle <23693150+ohaiibuzzle@users.noreply.github.com>
Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>
TheMoonThatRises pushed a commit that referenced this pull request Aug 23, 2024
* Added PlayApp view state persistence

Issue from  Xyct:

This works perfectly with a showStartingProgress variable, but when isList is changed during starting, showStartingProgress is reset to false.

I then decide to rely on app.isStarting and update showStartingProgress from it, but something I don't understand happens: app.isStarting also resets to false. This not only lead to the not showing of the progress view when switching between List view and Grid view, but also makes the app can be launched multiple times during launching.

* Removed unnecessary import

* Recovered accidentally deleted code comment (oops)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants