feat: make shop screen optional #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the shop screen displayed with the inventory optional. This is done by introducing a new marker component `AllowShopScreenComponent` and a high-priority event handler to open a different screen if this component is present on a client. The README contains a section explaining how the screen can be enabled.
|
I tested this with MetalRenegades by adding the code snippet to the I did not test it yet whether the enabling can be done purely on client-side. In theory, this approach now allows to programmatically control when the player is able to access the in-game shop. We could, for instance, add the respective component to the client only if they are in close proximity to their home base (in Light&Shadow) or during specific time slots (in Gooey's Defense). |
jdrueckert
reviewed
Dec 3, 2021
src/main/java/org/terasology/economy/ui/MarketUiClientSystem.java
Outdated
Show resolved
Hide resolved
This was referenced Dec 4, 2021
jdrueckert
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the shop screen displayed with the inventory optional.
This is done by introducing a new marker component
AllowShopScreenComponentand a high-priority event handler to open a different screen if this component is present on a client.The README contains a section explaining how the screen can be enabled.