Skip to content

Conversation

watermelon42
Copy link
Contributor

@watermelon42 watermelon42 commented Jun 18, 2025

This PR adds support for importing Soundcloud likes, adds a new tab Likes in channels of SoundCloud, a minor GUI change.
The likes are also retrieved in the feed if the user is subscribed to.

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Adds a new tab, Likes, to a Soundcloud user's channel.
  • Import likes in the What's New tab.
  • The two things above can be managed in Settings -> Content.

Before/After Screenshots/Screen Record

Fixes the following issue(s)

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jun 18, 2025
@watermelon42
Copy link
Contributor Author

watermelon42 commented Jun 18, 2025

TESTS:

Switch to Soundcloud view.

Test case 1: User with no likes shows empty Likes tab.

  1. Search for dubtil Soundcloud user using the magnifying glass icon from the New and hot screen.
  2. Open the account.
  3. Go to the Likes tab, the 4th tab.
  4. Validate that the list contains only crickets.

Test case 2: Likes are loaded correctly for user with single page of likes

  1. Search for liluzivert Soundcloud user using the magnifying glass icon from the New and hot screen.
  2. Open the account.
  3. Go to the Likes tab, the 4th tab.
  4. Validate that the list contains few tracks.

Test case 3: Likes are loaded correctly for user with multiple pages of likes

  1. Search for polysormi Soundcloud user using the magnifying glass icon from the New and hot screen.
  2. Open the account.
  3. Go to the Likes tab, the 4th tab.
  4. Validate that the list contains lots of tracks.
  5. Validate that the list contains liked playlists.
  6. Scroll down until more loading occurs.
  7. Validate it works.

Test case 4: Subscribing to a Soundcloud user shows Likes in What's New screen

  1. Search for lubenitza Soundcloud user using the magnifying glass icon from the New and hot screen.
  2. Open the account.
  3. Subscribe to the user.
  4. Go back to the main Soundcloud screen.
  5. Switch to the What's New tab, the 2nd tab.
  6. Refresh.
  7. Validate that the feed contains tracks from the user's likes.

Test case 5: Remove the Likes tab from settings

  1. Go to Settings -> Content -> Channel tabs.
  2. Deselect Likes.
  3. Go back to the main Soundcloud screen.
  4. Search for lubenitza Soundcloud user using the magnifying glass icon from the New and hot screen.
  5. Open the account.
  6. Validate there is no Likes tab visible.

Test case 6: Remove the Likes from the feed

  1. Go to Settings -> Content -> Fetch channel tabs.
  2. Deselect Likes.
  3. Go back to the main Soundcloud screen.
  4. Search for lubenitza Soundcloud user using the magnifying glass icon from the New and hot screen.
  5. Open the account.
  6. Subscribe to the user.
  7. Go back to the main Soundcloud screen.
  8. Switch to the What's New tab, the 2nd tab.
  9. Refresh.
  10. Validate that the feed doesn't contain any tracks from the user's likes.

Test case 7: Likes are loaded correctly in the queue for playing

  1. Search for polysormi Soundcloud user using the magnifying glass icon from the New and hot screen.
  2. Open the account.
  3. Go to the Likes tab, the 4th tab.
  4. Tap the Play All button.
  5. Open the play queue.
  6. Validate the queue contains the user's liked tracks.
  7. Validate none of the user's liked playlists are in the queue - this is a limitation of the current implementation of NewPipe.

@ShareASmile ShareASmile added feature request Issue is related to a feature in the app soundcloud Service, https://soundcloud.com/ labels Jun 18, 2025
@ShareASmile ShareASmile added GUI Issue is related to the graphical user interface channel Anything to do with creator channels in the app labels Jun 20, 2025
@watermelon42 watermelon42 requested a review from ShareASmile June 21, 2025 16:13
@ShareASmile ShareASmile requested review from Stypox and removed request for ShareASmile July 8, 2025 16:08
…ut` in a user's channel.

The likes are also retrieved in the feed if the user is subscribed to.
@TobiGr TobiGr force-pushed the 3783_Import_Soundcloud_likes branch from b169d9f to 1c0eabf Compare July 13, 2025 14:21
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I updated the extractor commit to match the latest version and squashed your commits a little

@watermelon42
Copy link
Contributor Author

Thank you. I updated the extractor commit to match the latest version and squashed your commits a little

Thank you! I'm looking forward for the new release!

@TobiGr TobiGr merged commit 4c920a4 into TeamNewPipe:dev Jul 14, 2025
5 checks passed
@watermelon42 watermelon42 deleted the 3783_Import_Soundcloud_likes branch July 14, 2025 08:10
@Stypox Stypox mentioned this pull request Jul 17, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel Anything to do with creator channels in the app feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface size/small PRs with less than 50 changed lines soundcloud Service, https://soundcloud.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import likes from Soundcloud account
3 participants