-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Support Soundcloud likes in channel and feed #12367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Soundcloud likes in channel and feed #12367
Conversation
TESTS: Switch to Soundcloud view. Test case 1: User with no likes shows empty
Test case 2: Likes are loaded correctly for user with single page of likes
Test case 3: Likes are loaded correctly for user with multiple pages of likes
Test case 4: Subscribing to a Soundcloud user shows Likes in What's New screen
Test case 5: Remove the
Test case 6: Remove the
Test case 7: Likes are loaded correctly in the queue for playing
|
…ut` in a user's channel. The likes are also retrieved in the feed if the user is subscribed to.
b169d9f
to
1c0eabf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I updated the extractor commit to match the latest version and squashed your commits a little
Thank you! I'm looking forward for the new release! |
This PR adds support for importing Soundcloud likes, adds a new tab
Likes
in channels of SoundCloud, a minor GUI change.The likes are also retrieved in the feed if the user is subscribed to.
What is it?
Description of the changes in your PR
Likes
, to a Soundcloud user's channel.What's New
tab.Before/After Screenshots/Screen Record
Channel: https://postimg.cc/TyXdbDZz
Feed: https://postimg.cc/s12V5yNg
Channel: https://postimg.cc/ZCB4DHZk
Feed: https://postimg.cc/RqbvR8kQ
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence