chore(page): leverage answer engine before create new page #4237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0d0778 to
fe76d62
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (28.57%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4237 +/- ##
==========================================
- Coverage 55.65% 55.54% -0.12%
==========================================
Files 238 238
Lines 30092 30177 +85
==========================================
+ Hits 16749 16762 +13
- Misses 13343 13415 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the AnswerService into the page creation flow to leverage answer generation before a new page is created. Key changes include:
- Introducing AnswerService in the PageService implementation with answer stream processing.
- Updating function signatures and dependency injections to support the new answer engine.
- Adjusting tests and module initializations to accommodate AnswerService.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ee/tabby-webserver/src/service/page.rs | Integrates AnswerService; adds answer stream looping and message construction. |
| ee/tabby-webserver/src/service/mod.rs | Updates page service creation to depend on both chat and answer services. |
| ee/tabby-webserver/src/service/answer/testutils/mod.rs | Moves answer config helper functions to a shared location. |
| ee/tabby-webserver/src/service/answer.rs | Refactors test-related answer configurations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug log indicates that the answer was invoked prior to the page generation:
New Page has more details:
