Skip to content

Conversation

Br1ght0ne
Copy link
Contributor

Applied Clippy lints with cargo clippy --fix and manually refactored some to make Clippy report 0 warnings :)

Notes:

  • will every supported shell have completions? if not, changing signature of customize_completions might've been a bad move.

@Br1ght0ne Br1ght0ne changed the title Apply clippy lints [WIP] Apply clippy lints Apr 27, 2021
@TaKO8Ki TaKO8Ki self-requested a review April 27, 2021 13:26
@TaKO8Ki
Copy link
Owner

TaKO8Ki commented Apr 27, 2021

@Br1ght0ne

Thank you for your contribution!

will every supported shell have completions? if not, changing signature of customize_completions might've been a bad move.

Yes. frum support bash, zsh and fish now. And I'm planning to support customized fish shell completion.

@TaKO8Ki
Copy link
Owner

TaKO8Ki commented Apr 28, 2021

@Br1ght0ne
Is this PR still work-in-progress?

@Br1ght0ne Br1ght0ne marked this pull request as ready for review April 28, 2021 13:00
@Br1ght0ne Br1ght0ne changed the title [WIP] Apply clippy lints Apply clippy lints Apr 28, 2021
Copy link
Owner

@TaKO8Ki TaKO8Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TaKO8Ki TaKO8Ki merged commit f6b5139 into TaKO8Ki:main Apr 28, 2021
@Br1ght0ne
Copy link
Contributor Author

@TaKO8Ki Forgot to mark as ready. Thank you!

@Br1ght0ne Br1ght0ne deleted the clippy-fix branch April 28, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants