Skip to content

Add --quiet flag to local #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 23, 2021
Merged

Add --quiet flag to local #43

merged 7 commits into from
Apr 23, 2021

Conversation

citizen428
Copy link
Contributor

@citizen428 citizen428 commented Apr 23, 2021 •
edited
Loading

Closes #42

This PR

  • adds a --quiet (-q) flag to the local subcommand and
  • updates the use_on_cd commands for the various shells to use this flag.

@TaKO8Ki
Copy link
Owner

TaKO8Ki commented Apr 23, 2021 •
edited
Loading

Thank you for your contribution! Could you add pull_request trigger to ci.yml like the following and run CI? I forgot to add it.

# ci.yml
push:
  branches:    
    - '**'
  tags-ignore:
    - v*
  paths-ignore:
    - 'LICENSE'
    - '**.md'
pull_request:
  paths-ignore:
    - 'LICENSE'
    - '**.md'

@TaKO8Ki TaKO8Ki self-requested a review April 23, 2021 16:35
@TaKO8Ki TaKO8Ki linked an issue Apr 23, 2021 that may be closed by this pull request
[FEATURE REQUEST] frum --quiet or -q #41
Closed
@TaKO8Ki
Copy link
Owner

TaKO8Ki commented Apr 23, 2021

LGTM

After CI passes, I will approve this PR.

TaKO8Ki
TaKO8Ki approved these changes Apr 23, 2021
View reviewed changes
Copy link
Owner

@TaKO8Ki TaKO8Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TaKO8Ki TaKO8Ki merged commit 8a3341f into TaKO8Ki:main Apr 23, 2021
@citizen428 citizen428 deleted the citizen428/add-quiet-flag-to-local-42 branch April 24, 2021 01:46
@TaKO8Ki TaKO8Ki mentioned this pull request Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaKO8Ki TaKO8Ki TaKO8Ki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn off error messages after running cd command [FEATURE REQUEST] frum --quiet or -q
2 participants
@citizen428 @TaKO8Ki