Skip to content

fix(starr): remove sphd #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

fix(starr): remove sphd #2426

merged 1 commit into from
Jul 14, 2025
+2 −2

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Jul 13, 2025 •
edited by sourcery-ai bot
Loading

Pull Request

Purpose

I incorrectly assumed the regex was case sensitive, and now it's marking SPHD as scene when it should only be sPHD.

Since sPHD is not really popular, it makes sense to remove it.

Approach

Open Questions and Pre-Merge TODOs

Requirements

Summary by Sourcery

Bug Fixes:

  • Remove the sPHD custom format entry from Radarr and Sonarr scene JSON to prevent uppercase SPHD from being misclassified as scene

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Jul 13, 2025 •
edited
Loading

Reviewer's Guide

Removed the SPHD pattern from the scene custom format for both Radarr and Sonarr by deleting its JSON entry, ensuring only the intended lowercase 'sPHD' is not erroneously matched.

File-Level Changes

Change Details Files
Removed SPHD from scene custom formats
  • Deleted the 'sphd' pattern entry from the Radarr scene.json
  • Deleted the 'sphd' pattern entry from the Sonarr scene.json
 docs/json/radarr/cf/scene.json
docs/json/sonarr/cf/scene.json
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Jul 13, 2025
sourcery-ai[bot]
sourcery-ai bot reviewed Jul 13, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lucacome - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions GitHub Actions
Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:fd8085917edd57a246dacdfe84361e6ce44583db
Status: ✅  Deploy successful!
Preview URL:https://0e5c1a2e.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2426.trash-guides-6xu.pages.dev

TRaSH-
TRaSH- approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx
I already got a report for it, i completely forgot the valid RlsGrp

@TRaSH- TRaSH- merged commit 264f256 into TRaSH-Guides:master Jul 14, 2025
11 checks passed
@lucacome lucacome deleted the fix-scene branch July 14, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@TRaSH- TRaSH- TRaSH- approved these changes

Assignees
No one assigned
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacome @TRaSH-