Skip to content

Conversation

TBSniller
Copy link
Owner

We have updated hyperion-webos to be a native service.
The nodeJS-service isn't needed anymore.
Updated hyperion-webos
Merged impressions from @Informatic
Fixed up UI

@Informatic: Could you please take a look at this?
Thanks!

@Informatic
Copy link
Collaborator

That's definitely a bug in service implementation, and definitely should be fixed there (though I couldn't reproduce it here?)

Does it actually start up the service in that case, and just not send a reply? I think a call should return with an error anyways, if a backing service just crashes mid-request.

@TBSniller
Copy link
Owner Author

Yeah it starts up, but after a normal reboot it has entered failsafe mode and I had to disable it.
It looked like: Boot -> autostart PicCap -> reboot -> Failsafe -> disable failsafe -> reboot -> autostart PicCap -> reboot -> failsafe -> ....

Edited the script, until now two restarts and everything went well. Will take a look the next days

@Informatic
Copy link
Collaborator

Informatic commented Dec 31, 2021

Sure, but this will also leave dangling luna-send execution in the background. I think we should probably rather use timeout or something similar, if we really weren't able to resolve it service-side.

Copy link
Collaborator

@Informatic Informatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at two final comments and we can merge this in.

@TBSniller
Copy link
Owner Author

Waiting on some tests here: https://github.com/TBSniller/piccap/releases/tag/0.2.1

@TBSniller
Copy link
Owner Author

Final tests done

@TBSniller TBSniller merged commit 662cda5 into main Jan 21, 2022
@TBSniller TBSniller deleted the task/native-service branch January 21, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants