-
Notifications
You must be signed in to change notification settings - Fork 38
PicCap using native hyperion-webos service #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into task/native-service
That's definitely a bug in service implementation, and definitely should be fixed there (though I couldn't reproduce it here?) Does it actually start up the service in that case, and just not send a reply? I think a call should return with an error anyways, if a backing service just crashes mid-request. |
Yeah it starts up, but after a normal reboot it has entered failsafe mode and I had to disable it. Edited the script, until now two restarts and everything went well. Will take a look the next days |
Sure, but this will also leave dangling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at two final comments and we can merge this in.
Waiting on some tests here: https://github.com/TBSniller/piccap/releases/tag/0.2.1 |
Final tests done |
We have updated hyperion-webos to be a native service.
The nodeJS-service isn't needed anymore.
Updated hyperion-webos
Merged impressions from @Informatic
Fixed up UI
@Informatic: Could you please take a look at this?
Thanks!