Make the "Show LightBulb" hotkey toggle the window on/off instead #378
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the hotkey functionality so that the "Show LightBulb" hotkey now toggles the window's visibility instead of solely focusing the window.
- Updated UI components with new labels and bindings in the settings tab
- Adjusted hotkey registration behavior in view models and application event handlers
- Modified service properties and Avalonia extensions to support the new toggle functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| LightBulb/Views/Components/Settings/HotKeySettingsTabView.axaml | Updated UI texts and bound properties for toggling functionality |
| LightBulb/ViewModels/MainViewModel.cs | Changed how the main window is activated when a hotkey event occurs |
| LightBulb/ViewModels/Components/Settings/HotKeySettingsTabViewModel.cs | Removed and added hotkey properties to align with new behavior |
| LightBulb/ViewModels/Components/DashboardViewModel.cs | Reconfigured hotkey registrations for toggling the window and enabling/disabling functionality |
| LightBulb/Utils/Extensions/AvaloniaExtensions.cs | Replaced the focus method with a toggle method to support hiding/showing |
| LightBulb/Services/SettingsService.cs | Updated hotkey properties with JSON mapping changes to accommodate new functionality |
| LightBulb/App.axaml.cs | Updated TrayIcon and settings menu click events to trigger toggle actions |
| LightBulb/App.axaml | Updated menu item texts to reflect the new toggling and enabling/disabling behavior |
|
|
||
| [ObservableProperty] | ||
| public partial HotKey ToggleHotKey { get; set; } | ||
| [JsonPropertyName("FocusWindowHotKey")] |
There was a problem hiding this comment.
The JSON property name 'FocusWindowHotKey' does not match the new property name 'ToggleWindowHotKey', which could confuse consumers or lead to incorrect serialization mappings. Consider updating the JSON attribute to reflect the current property name for clarity and consistency.
Copilot uses AI. Check for mistakes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 7 7
Lines 192 192
Branches 15 15
=======================================
Hits 185 185
Misses 6 6
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.