Use librespot libraries instead of its binary crate #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build error is unrelated |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Rebased on latest master. Can you take a quick look at this PR please? It removes 15 dependencies that were pulled in by librespot's binaries, and thus were unused by spotifyd. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Stale or not, this PR can be closed in favor of #977 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
librespot's main crate is just a reexport of its sub-modules: https://github.com/librespot-org/librespot/blob/v0.1.5/src/lib.rs#L4
The number of dependencies on spotifyd can be reduced by depending on librespot's sub-modules instead, this PR does that.
I didn't bump librespot's version to the latest 0.2 since it depends on tokio 1 instead of tokio 0.1.
Note: this PR has the side effect of doing a
cargo updateon the librespot dep