Fixed Linting issues in src/setup.rs #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduced unnecessary complexity from setup.rs by replacing match for boolean with matches! macro.
robinvd
previously approved these changes
Jan 2, 2021
JojiiOfficial
previously approved these changes
Jan 2, 2021
|
@nkitan could you fix the codestyle ci error? |
robinvd
approved these changes
Jan 12, 2021
JojiiOfficial
approved these changes
Jan 12, 2021
|
merging even though the ci still gives some errors |
|
@robinvd We can do that? |
|
Yes! I thing temporarily, see #604. Still need 2 reviews though. Glad we can reduce the pr backlog a bit |
|
Okay good to know. I didn't see that issue. Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduced unnecessary complexity from setup.rs by replacing match for boolean with matches! macro.
lint error fix for #740