Wow, what a PR streak! :)

So I've thought about this for some time today. I feel like the flag should not be a value within the config file and only a CLI flag as it's used for debugging only and not for configuration.

So the ideal case would be to move the Debug implementation to CliConfig. This is needed as SharedConfigValues is part of CliConfig. And we could then use your code there.

I am actually not sure if that would work without problems whatsoever without having the compiler spitting out some errors. So I would rather try this one out at the weekend. That way I am wasting some time and not you if it doesn't work ;)

Wow, what a PR streak! :)

So I've thought about this for some time today. I feel like the flag should not be a value within the config file and only a CLI flag as it's used for debugging only and not for configuration.

So the ideal case would be to move the Debug implementation to CliConfig. This is needed as SharedConfigValues is part of CliConfig. And we could then use your code there.

I am actually not sure if that would work without problems whatsoever without having the compiler spitting out some errors. So I would rather try this one out at the weekend. That way I am wasting some time and not you if it doesn't work ;)

I agree with you, that makes a lot more sense.
I could play around a bit with it and maybe post some snippets in here (to avoid another PR and commit massacre :D), but this might go above my understanding of Rust.

Glad my effort was at least worth something. :)

You can create as many commits as you like. I Squash them together before merging anyway :) People always underestimate contributions they make :)

And there is no better way to learn a new language then trying out ;)

I just looked at the code and I think while you are rewriting the Debug implementation anyway we should change the line I added in #357.

From .field("no-audio-cache", &self.no_audio_cache) to .field("audio-cache", &!self.no_audio_cache) in line 349.

This might clear things up in the output.

Thanks for your effort Tobi! I think a move of the Debug might be a better option though. So I’ll close this one for now.