Expose librespots support for limiting the cache size #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a config entry Fixes Spotifyd#1066
eladyn
requested changes
Jun 28, 2022
There was a problem hiding this comment.
Thanks for the PR!
There are still some places, where you'd need to add the new flag as well:
- merging of the different configuration sources, otherwise the value can't be set in the config file
- struct debugging, so that the value is logged with
--verbose - docs, if possible, with some documenting lines
|
@slondr Any chance on merging this? |
robinvd
approved these changes
Jul 11, 2022
slondr
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1066