-
Notifications
You must be signed in to change notification settings - Fork 479
Closed
Labels
bugA functionality or parts of a program that do not work as intendedA functionality or parts of a program that do not work as intendedenhancementA new feature that would improve SpotifydA new feature that would improve Spotifydgood first issueAn easy to implement issue, good for first time contributors or people new to open sourceAn easy to implement issue, good for first time contributors or people new to open sourcehelp wantedIssues that need help since the assigned person has little to no knowledge about the topicIssues that need help since the assigned person has little to no knowledge about the topic
Description
Description
currently when no x-server is available (or other dbus errors) we just panic, but this could just be a warning and then continue without dbus.
To Reproduce
- compile with dbus enables d
- run without an x-server (i thing unsetting DISPLAY should also work).
- run spotifyd normally
- crashes with a panic
Expected behavior
a warning, but not a panic
Logs
see #729 for a relevant issue.
Compilation flags
- dbus_mpris
- dbus_keyring
- alsa_backend
- portaudio_backend
- pulseaudio_backend
- rodio_backend
a quicker solution might be to provide a command line option to disable dbus.
relevant code locations:
- creating a dbus instance
Line 182 in 8cd1240
self.spotifyd_state.dbus_mpris_server = new_dbus_server(
this could be put behind an if triggered by a command line option, thus avoiding the panic. Line 175 in a863582
Connection::get_private(BusType::Session).expect("Failed to initialize DBus connection"),
this is where the panic happens, instead there could be a logger warning, and return something else
Metadata
Metadata
Assignees
Labels
bugA functionality or parts of a program that do not work as intendedA functionality or parts of a program that do not work as intendedenhancementA new feature that would improve SpotifydA new feature that would improve Spotifydgood first issueAn easy to implement issue, good for first time contributors or people new to open sourceAn easy to implement issue, good for first time contributors or people new to open sourcehelp wantedIssues that need help since the assigned person has little to no knowledge about the topicIssues that need help since the assigned person has little to no knowledge about the topic