Skip to content

Dear ImGui 1.87 #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 16, 2024
Merged

Dear ImGui 1.87 #252

merged 15 commits into from
Aug 16, 2024

Conversation

SpaiR
Copy link
Owner

@SpaiR SpaiR commented Aug 16, 2024

Description

This PR updates Dear ImGui to v1.87 and ImPlot to v0.13. The ImPlot update was necessary due to broken compatibility with Dear ImGui v1.87.

Both updates introduce a significant amount of new API, so it's highly recommended to read the release notes for the original libraries.

Other Changes

  • ImGuiImplGlfw and ImGuiImplGL3 have been synced with the versions from the v1.87 release. There are numerous changes on the GLFW side to adapt to the new IO API. Additionally, both backends have been re-written to be almost exact 1:1 copies of the original code. This will simplify future updates and reduce the likelihood of errors from missing components.
  • Fixed an issue that prevented setting struct fields of the char * type.
  • Corrected a problem where some Java-side structs did not call super in their constructors.

Type of change

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

SpaiR added 14 commits August 12, 2024 16:56
@SpaiR
build(deps): bump Dear ImGui from 1.86 to 1.87
7f5b06c
@SpaiR
build(deps): bump implot from 0.12 to 0.13
df84468
@SpaiR
feat(api,binding): adapt API to Dear ImGui v1.87
95a6d71
@SpaiR
feat(api,binding): adapt API to implot v0.13
94c1eb2
@SpaiR
build: generate API for latest changes
b6f4707
@SpaiR
chore(binding): add missing super call for ImGuiStructDestroyable con…
7709b7a 
…structor
@SpaiR
chore: minor code style
c4cf8a9
@SpaiR
feat: adapt ImGuiImplGlfw to 1.87
80d20df
@SpaiR
feat: adapt ImGuiImplGl3 to 1.87
4b007f0
@SpaiR
feat: adapt imgui-app module to 1.87
11230b1
@SpaiR
fix: javadoc for updated imgui-binding
f3bc018
@SpaiR
fix: loosing data when setting struct field of char* type
9ee1f12 
Since we manually release chars, to store them in field we need to do a local copy.
@SpaiR
fix: invalid methods to check program linking in OpenGL
58c6e9d
@SpaiR
chore: remove dedicated method to check GLFW version
03b6872
@SpaiR SpaiR added feat New feature or request api fix Fixes problems deps Pull requests that update a dependency file labels Aug 16, 2024
@SpaiR SpaiR self-assigned this Aug 16, 2024
@SpaiR SpaiR force-pushed the feat/dear-imgui-1.87 branch from 0af9b19 to 4cd7410 Compare August 16, 2024 11:06
@SpaiR SpaiR merged commit 47d9710 into main Aug 16, 2024
7 checks passed
@SpaiR SpaiR deleted the feat/dear-imgui-1.87 branch August 16, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SpaiR SpaiR

Labels
deps Pull requests that update a dependency file feat New feature or request fix Fixes problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SpaiR