use versioned install.sh with variables in action.yml #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchan0130
reviewed
May 15, 2025
| @@ -25,7 +25,7 @@ runs: | |||
| cd "${GITHUB_WORKSPACE}" || exit 1 | |||
| TEMP_PATH="$(mktemp -d)" | |||
| PATH="${TEMP_PATH}:$PATH" | |||
| curl -sfL https://raw.githubusercontent.com/Songmu/tagpr/v1.5.2/install.sh | sh -s -- -b "$TEMP_PATH" "${{ inputs.version }}" 2>&1 | |||
| curl -sfL "https://raw.githubusercontent.com/Songmu/tagpr/${{ inputs.version }}/install.sh" | sh -s -- -b "$TEMP_PATH" "${{ inputs.version }}" 2>&1 | |||
There was a problem hiding this comment.
This is incorrect for the behavior to be dictated by ${{ inputs.version }}, as this refers to the version of the tagpr binary, which can be arbitrarily set by the end user.
In GitHub Actions, users expect that the specified version of the action itself is what gets executed.
Therefore, the version of the action and the version of the installer should be expected to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor fix following #201