Reducing supply chain risk at actions #201
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchan0130
commented
May 15, 2025
| @@ -25,7 +25,7 @@ runs: | |||
| cd "${GITHUB_WORKSPACE}" || exit 1 | |||
| TEMP_PATH="$(mktemp -d)" | |||
| PATH="${TEMP_PATH}:$PATH" | |||
| curl -sfL https://raw.githubusercontent.com/Songmu/tagpr/main/install.sh | sh -s -- -b "$TEMP_PATH" "${{ inputs.version }}" 2>&1 | |||
| curl -sfL https://raw.githubusercontent.com/Songmu/tagpr/v1.5.2/install.sh | sh -s -- -b "$TEMP_PATH" "${{ inputs.version }}" 2>&1 | |||
There was a problem hiding this comment.
I am aware that this version value is automatically updated by https://github.com/Songmu/tagpr/blob/main/.tagpr#L20.
There was a problem hiding this comment.
ops.. https://github.com/Songmu/tagpr/blob/6f76534e4066713c6b49eac9aedd44887f9eb15d/action.yml
It might be better to allow the version to be set via an environment variable.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of the action, even when we pin a specific version, the installer is still fetched from the
mainbranchHEAD.This behavior introduces a significant supply chain security risk, as it allows unreviewed or unintended changes in the main branch to be executed in user workflows.
To address this, I have modified the implementation to reduce this risk and ensure more predictable and secure behavior.