Support signed commit #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I'll take a look later. |
|
Thank you. I will merge this. Please let me know if any additional permissions are required for the token as a result of this change. |
|
Thank you for merging! Here is a list of the APIs used in this implementation:
To use these APIs, the following permissions are generally sufficient.
Only when updating a GitHub Actions workflow file using tagpr, the following additional permission is required.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Verified commits when tagpr opens a pull request.
Related Issue
Closes #196
Motivation
Users asked that commits generated by tagpr show GitHub’s green Verified badge.
According to GitHub docs, a bot commit is signed when the no custom author information, custom committer information, etc... from the Commits API payload.
Implementation Details
Signed commits
By leaving out any custom
author,committerfields inPOST /repos/{owner}/{repo}/git/commits, GitHub automatically attaches a verified bot signature.git commit -alogicgit diff --name-status HEADto detect both staged and unstaged changes (including files staged bytagpr.command).cherry-picklogicRe-writing the author field would invalidate GitHub’s verified signature, so this trade-off is intentional.
FYI