-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add SV06 high-speed settings which were incomplete earlier #8648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Apoorv Parle <19315187+apparle@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Can you take a look at my comment?
@SoftFever not sure you closed this by mistake or assumed I'm not responding. Also, I did check with the commit you highlighted and it doesn't have any changes under Sovol directory, so no conflicts. I'm still interested in getting this merge, so can you please open this again? |
Sure thing, let me re-open it. I initially closed it so I wouldn’t keep checking the PR status. But now that I think about it, it’s probably better to convert it to a draft or add a label instead of closing it. Anyway, feel free to re-open the PR! In the future, it’d be helpful to leave a message to let me know. |
I wasn’t referring to conflicts. |
The temperature settings are different between the 2 files are different once I trace through all the "inherits" and look at the final settings. |
Thanks for the clarification. |
No, there isn't specific to a filament brand, AFAIK there isn't even a "Sovol SV06" brand filament at all. I'm using these with a Hatchbox PLA filament. Sovol provided these profiles along with the high-speed firmware here, specifically for the high-speed usage of the SV06 model printer, so they may have studied this. I'm guessing SV06 printer requires higher temperature than usual for a faster flowing filament when machine is using higher acceleration. |
Understood, and I appreciate it! This community sharing and caring thing is the core value of OrcaSlicer! |
… types of filaments. Signed-off-by: Apoorv Parle <19315187+apparle@users.noreply.github.com>
Updated to remove the filament. Also added other Generic filament types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you.
I will make some adjustments later once this PR is merged.
Description
Sovol introduced a high-speed firmware + profile an year back. That profile was initially merged into Orcaslicer as part of #5673 and #5675 . But it looks like that only updated the process json.
That is incomplete without updated nozzle acceleration settings & filament settings, rendering the High-speed profile broken and no faster than default. Someone else also observed this on #5673
This PR contains rest of the profile changes from Sovol with some minor modifications:
Tests
I've tested this with 2.2.0 flatpak locally.