-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Merged Orca-Flashforge 1.3 branch (Added AD5X & G4P) + fixes & optimizations #8461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @RikshaDriver |
I'll double check the Fusrock profiles but the Flashforge 0.25mm nozzle filament profiles have been deliberately renamed to keep filament settings consistent with Generic filament and Flashforge specific filament profiles. Do you see any issues with this? |
I see. |
Ah excellent! Will update soon! |
Added AD5X & G4P Consolidated/Revised AD3, AD5M & G2S profiles Commenced filament Filament ID & Setting ID corrections
@SoftFever fixed now. Once this is merged, I will load additional profiles for other filament vendors @Bai825 I have reorganized filament settings into Flashforge and Generic filaments. All the Flashforge specific filaments in the Flashforge folder should have vendor as Flashforge. Refer to Flashforge PLA *.json |
prettified/simplified json formatting using jj
@SoftFever I have created a crude script to recursively prettify JSON files in a dir using jj (https://github.com/tidwall/jj)... It currently has no error checking, but it makes the json profiles visually far easier to manage and keeps indentation consistent |
Looks good |
* Revert "fix more Flashforge issues" This reverts commit 6e473fd. * Revert "Fixed an issue that some Flashforge filament profiles don't' have compatible_printers defined which cause filament selection dialog didn't filter properly" This reverts commit f8c0cdf. * Revert "Merged Orca-Flashforge 1.3 branch (Added AD5X & G4P) + fixes & optimizations (#8461)" This reverts commit b8e4ce7, reversing changes made to be8bf54.
Added AD5X & G4P
Consolidated/Revised AD3, AD5M & G2S profiles
Commenced filament Filament ID & Setting ID corrections