Skip to content

Conversation

RikshaDriver
Copy link
Contributor

Added AD5X & G4P
Consolidated/Revised AD3, AD5M & G2S profiles
Commenced filament Filament ID & Setting ID corrections

@SoftFever
Copy link
Owner

Thanks @RikshaDriver
There are some errors.
Can you have a look?

@RikshaDriver
Copy link
Contributor Author

RikshaDriver commented Feb 19, 2025

I'll double check the Fusrock profiles but the Flashforge 0.25mm nozzle filament profiles have been deliberately renamed to keep filament settings consistent with Generic filament and Flashforge specific filament profiles.

Do you see any issues with this?

@SoftFever
Copy link
Owner

I see.
Orca now supports "renamed_from" attribute.
You can add such an attribute so that it won't break compatibility
"renamed_from":"old_name"

@RikshaDriver
Copy link
Contributor Author

I see.

Orca now supports "renamed_from" attribute.

You can add such an attribute so that it won't break compatibility

"renamed_from":"old_name"

Ah excellent!

Will update soon!

Added AD5X & G4P
Consolidated/Revised AD3, AD5M & G2S profiles
Commenced filament Filament ID & Setting ID corrections
@RikshaDriver
Copy link
Contributor Author

RikshaDriver commented Feb 20, 2025

@SoftFever fixed now. Once this is merged, I will load additional profiles for other filament vendors

@Bai825 I have reorganized filament settings into Flashforge and Generic filaments.
Refer to Flashforge PLA *.json and Flashforge Generic PLA *.json for updated filament_id and setting_id parameters. All of the filaments are currently the same, but they should be differentiated.

All the Flashforge specific filaments in the Flashforge folder should have vendor as Flashforge. Refer to Flashforge PLA *.json

prettified/simplified json formatting using jj
@RikshaDriver RikshaDriver changed the title Merged Orca-Flashforge 1.3 branch + fixes & optimizations Merged Orca-Flashforge 1.3 branch (Added AD5X & G4P) + fixes & optimizations Feb 20, 2025
@RikshaDriver
Copy link
Contributor Author

RikshaDriver commented Feb 20, 2025

@SoftFever I have created a crude script to recursively prettify JSON files in a dir using jj (https://github.com/tidwall/jj)... It currently has no error checking, but it makes the json profiles visually far easier to manage and keeps indentation consistent

prettify_json.zip

@SoftFever
Copy link
Owner

Looks good
Thank you

@SoftFever SoftFever merged commit b8e4ce7 into SoftFever:main Feb 20, 2025
1 check passed
SoftFever added a commit that referenced this pull request Feb 22, 2025
…& optimizations (#8461)"

This reverts commit b8e4ce7, reversing
changes made to be8bf54.
SoftFever added a commit that referenced this pull request Feb 22, 2025
* Revert "fix more Flashforge issues"

This reverts commit 6e473fd.

* Revert "Fixed an issue that some Flashforge filament profiles don't' have compatible_printers defined which cause filament selection dialog didn't filter properly"

This reverts commit f8c0cdf.

* Revert "Merged Orca-Flashforge 1.3 branch (Added AD5X & G4P) + fixes & optimizations (#8461)"

This reverts commit b8e4ce7, reversing
changes made to be8bf54.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants